PDA

View Full Version : Contributing


rbellamy
12-04-2005, 11:48 PM
I'm very new to Spring.NET, and find the framework quite compelling. I had to do some small, housekeeping-style work on the Pool example to get it to work with CVS HEAD... which got me to wondering:

1. Is there a style guide for patches (e.g. log4net [1]) or code (e.g. #develop [2], nunit [3], nant[4], etc)? In particular, I note that you guys use ReSharper - I'm wondering if you have a consistent config file for reformatting the code?
2. What's the procedure for submitting patches?
3. What's the procedure for becoming a contributor?

[1] http://logging.apache.org/log4net/contributing.html#patch
[2] http://www.sharpdevelop.com/TechNotes/SharpDevelopCodingStyle03.pdf
[3] http://www.nunit.org/community.html
[4] http://sourceforge.net/docman/display_doc.php?docid=6080&group_id=31650

Aleks Seovic
12-05-2005, 12:24 AM
Hi,

We've been keeping the whole process fairly open so far, and don't really have any formal style guides for patches, other than the general coding guidelines (http://opensource2.atlassian.com/confluence/spring/display/NET/Coding+Conventions) on the wiki.

The procedure for sumbitting patches is that you email them to Mark Pollack and/or myself, and we will look at them and either apply them (most likely) or come back to you with the additional questions if there is something in the code that we don't understand.

Once you have submitted a few significant patches we will give you comitter rights, if you want them, of course :-) Also, if there is a specific area of the framework where you would like to contribute you can explain what it is that you would like to do, and once we agree on the apporach you can go ahead and implement it. That would also be considered as a significant contribution and allow you to become a contributor.

Hope this answers your questions,

Aleks

rbellamy
12-05-2005, 12:39 AM
Aleks,

Thanks so much for your quick response!

The link to the coding guidelines on the wiki was exactly what I was looking for...

I'm sending a patch to the Pool example under seperate cover.